code-review skill: point at agent-rules Gates instead of restating it (improvise-vjus); two gate lessons in agent-rules
The restated list said cargo fmt --all --check, which reaches one of two workspace roots, and omitted direnv exec, checkers.sh and node-test.sh. agent-rules gains two rules from PRs #176 and #177. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VdfEGXA7aJ6ftMsCc9PJze
This commit is contained in:
@@ -95,17 +95,14 @@ From `design-principles.md` §7 and `doctrine/2`:
|
||||
|
||||
## Verifying
|
||||
|
||||
Run the gate **CI runs**, flags and all. Clippy exits 0 on warnings, so without
|
||||
`-D warnings` this file was green on exactly the input CI is red on — a check
|
||||
that cannot fail in the direction the defect lies.
|
||||
|
||||
```bash
|
||||
cargo test --workspace --no-fail-fast # fail-fast hides the blast radius
|
||||
cargo clippy --workspace --all-targets -- -D warnings
|
||||
cargo fmt --all --check
|
||||
python3 scripts/check-comment-runs.py # the two-line comment cap
|
||||
python3 scripts/check-comment-runs.py --check-evidence # a DIFFERENT question
|
||||
```
|
||||
Run the gate **CI runs**, flags and all. The list is
|
||||
`.agents/skills/wave/agent-rules.md`, "Gates", and it is kept only there. Run
|
||||
it from that file rather than from memory or from an older copy. A second
|
||||
copy of that list lived here and drifted: it said `cargo fmt --all --check`,
|
||||
which reaches only one of this repo's two workspace roots, and it left out
|
||||
`direnv exec .`, `scripts/checkers.sh` and `scripts/node-test.sh`
|
||||
(improvise-vjus). Flags matter. Clippy exits 0 on warnings, so without
|
||||
`-D warnings` a clippy run was green on exactly the input CI is red on.
|
||||
|
||||
**`--check-evidence` is additive**, so it answers the comment cap too and both
|
||||
verdicts print. It did not always: the flag used to *select*, so the flagged
|
||||
|
||||
@@ -74,6 +74,12 @@ direnv exec . ./scripts/node-test.sh 'web/tests/*.test.js'
|
||||
`cargo check --target wasm32-unknown-unknown -p <crate>` **for each crate**.
|
||||
CI checks each one separately, so feature unification cannot hide a leak.
|
||||
- If you touch `web/` or `harness/`, run the Playwright suite in `harness/`.
|
||||
- **If you change the grid's row or column count, also grep
|
||||
`harness/fixtures/*.improv` and `harness/tests/*.spec.js`.** On PR #176 a
|
||||
Playwright spec pinned the old collapsed-group row count. `cargo test` cannot
|
||||
see that.
|
||||
- **A PR that conflicts with its base gets no CI run.** So anything "left to
|
||||
CI" is unchecked until the PR is mergeable (PR #177).
|
||||
- **Measure your own baseline** before changing anything, and report it with
|
||||
the machine it was measured on. A figure from the brief is a reference, not
|
||||
your baseline.
|
||||
|
||||
Reference in New Issue
Block a user