fiddlerwoaroof/improvise
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style: cargo fmt the harness crate, which --all does not reach

Browse Source 
`harness/opfs-contract` carries its own [workspace] table, so it is not a
member of the root workspace -- deliberately, since it names
improvise_io::opfs and a member would break `cargo test --workspace`. The
consequence is that `cargo fmt --all -- --check` passes over it without
looking, so every gate I ran was honest and green while the file I had
edited was never visited.

It needs its own gate, as CI runs it:

    cd harness/opfs-contract
    cargo fmt -p opfs-contract -- --check
    cargo clippy --target wasm32-unknown-unknown --all-targets -- -D warnings

The gap is bounded: grepping for crates carrying their own [workspace]
table finds exactly this one and the root.

And a fmt failure is the FIRST step of that job, so the clippy behind it
never ran and nobody knew whether it was clean. It is -- verified locally
at this head, no warnings.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FC2jVn8Au7E9JPkw6bwXXH
This commit is contained in:
Edward Langley
2026-09-21 15:22:47 -07:00
parent a633613e56
commit 836323cafa
1 changed files with 18 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
harness/opfs-contract/src/lib.rs
+18 -15
View File
@@ -337,21 +337,24 @@ pub async fn run_probes() -> Result<String, JsError> {
// The 7gip guard, from the inside: the scope this really is must satisfy
// the NARROW type, or the fix would break the shipped path.
report
.run("a_dedicated_worker_satisfies_the_narrow_scope_guard", async || {
let global = js_sys::global();
ensure!(
global
.clone()
.dyn_into::<web_sys::DedicatedWorkerGlobalScope>()
.is_ok(),
"a dedicated worker did not satisfy DedicatedWorkerGlobalScope"
);
ensure!(
global.dyn_into::<web_sys::WorkerGlobalScope>().is_ok(),
"a dedicated worker did not satisfy WorkerGlobalScope either"
);
Ok("both, as expected here — the SharedWorker page is where they differ".into())
})
.run(
"a_dedicated_worker_satisfies_the_narrow_scope_guard",
async || {
let global = js_sys::global();
ensure!(
global
.clone()
.dyn_into::<web_sys::DedicatedWorkerGlobalScope>()
.is_ok(),
"a dedicated worker did not satisfy DedicatedWorkerGlobalScope"
);
ensure!(
global.dyn_into::<web_sys::WorkerGlobalScope>().is_ok(),
"a dedicated worker did not satisfy WorkerGlobalScope either"
);
Ok("both, as expected here — the SharedWorker page is where they differ".into())
},
)
.await;
Ok(report.finish())