fix: address three Codex P2 review findings

1. Shebang (Codex P2): scripts/agent-bootstrap.sh and .claude/hooks/session-start.sh
   now use #!/usr/bin/env bash instead of #!/bin/bash, matching repo convention
   enforced by checkers.sh.

2. Fail-closed bd pin (Codex P2): .claude/hooks/session-start.sh local path now
   exits 2 with a warning when pinned or running version cannot be parsed,
   instead of silently succeeding. An unparseable version is not a pass.

3. pr-reviews failure (Codex P2): scripts/pr-watch no longer uses '|| true' to
   swallow pr-reviews failures. If pr-reviews fails (fetch error, malformed
   response), pr-watch now exits 6 with a warning. Empty successful fetch
   (no reviews) is still exit 0.

   - Added exit 6 to usage text and skill documentation
   - Added test case 'pr-reviews failure exits 6' using malformed JSON fixture
   - All 57 pr-watch tests pass

Co-authored-by: Ed Langley <fiddlerwoaroof@users.noreply.github.com>

This commit is contained in:

Cursor Agent

2026-09-26 01:30:00 +00:00

parent b0c4105be3

commit ec30c8a7de

5 changed files with 45 additions and 16 deletions

									
										scripts/agent-bootstrap.sh
									
		+1
		-1
	
												View File
												
				@@ -1,4 +1,4 @@

				#!/bin/bash

				#!/usr/bin/env bash

				# Stack-agnostic agent bootstrap for this repository.

				#

				# This script prepares any coding agent (Claude Code, Cursor, etc.) to work