tooling: pr-reviews timeout case asserts WAIT+1 polls; a hang fails (7fl8)

improvise-7fl8: on the one-tick-per-read clock --wait 5 polls exactly 6
times, but the test asserted at least 5. So a loop capped at 5 polls, or
a deadline of now + WAIT - 1, passed at 25/25. It now asserts
polls = WAIT + 1, and both rivals fail it.

With the deadline check deleted, the suite used to hang at the first
real-clock timeout case. Every pr-reviews call now runs beside a
/bin/sleep watchdog (wait -n -p), and loses to it as exit 124. The same
rival now finishes in 93s with four FAILs.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VdfEGXA7aJ6ftMsCc9PJze

scripts/pr-reviews-test.sh

@@ -5,10 +5,25 @@
 set -uo pipefail
 
 here="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-REVIEWS="$here/pr-reviews"
 work="$(mktemp -d)"
 trap 'rm -rf "$work"' EXIT
 
+# Every run is bounded, so a loop that never stops FAILS (exit 124) rather than
+# hanging the suite. /bin/sleep, because some cases put a no-op `sleep` first on PATH.
+BOUND=20
+bounded_reviews() {
+  "$here/pr-reviews" "$@" &
+  local pid=$! dog done rc
+  /bin/sleep "$BOUND" &
+  dog=$!
+  wait -n -p done "$pid" "$dog"; rc=$?
+  if [ "$done" = "$pid" ]; then kill "$dog" 2>/dev/null; wait "$dog" 2>/dev/null; return "$rc"; fi
+  kill -TERM "$pid" 2>/dev/null; wait "$pid" 2>/dev/null
+  echo "pr-reviews-test: killed after ${BOUND}s; the --wait loop never stopped" >&2
+  return 124
+}
+REVIEWS=bounded_reviews
+
 pass=0; fail=0
 ok()  { printf '  ok   %s\n' "$1"; pass=$((pass+1)); }
 bad() { printf '  FAIL %s (%s)\n' "$1" "$2"; fail=$((fail+1)); }
@@ -240,15 +255,16 @@ polls=$(cat "$d3/.poll" 2>/dev/null || echo 0)
 [ "$got" = 0 ] && [ "$polls" = 3 ] && ok "a review arriving on the third poll is seen" \
   || bad "a review arriving on the third poll is seen" "exit $got after $polls polls, wanted 0 after 3"
 
-# The timeout path: nothing ever arrives, so --wait 5 on a clock that ticks
-# once per read must keep polling until the deadline, then report exit 1.
+# The timeout path: nothing arrives, and on a clock that ticks once per read the
+# count is exact: 1 poll, then one per tick until the deadline, so WAIT + 1.
+WAIT=5
 rm -f "$work/empty/.poll" "$work/ticks"
 CLOCK_TICKS="$work/ticks" PATH="$clock:$PATH" PR_REVIEWS_FIXTURE_DIR="$work/empty" \
-  "$REVIEWS" 1 --wait 5 --interval 1 > "$work/out" 2>&1
+  "$REVIEWS" 1 --wait "$WAIT" --interval 1 > "$work/out" 2>&1
 got=$?
 polls=$(cat "$work/empty/.poll" 2>/dev/null || echo 0)
-[ "$got" = 1 ] && [ "$polls" -ge 5 ] && ok "--wait keeps polling until its deadline" \
-  || bad "--wait keeps polling until its deadline" "exit $got after $polls polls, wanted 1 after 5 or more"
+[ "$got" = 1 ] && [ "$polls" = $((WAIT + 1)) ] && ok "--wait keeps polling until its deadline" \
+  || bad "--wait keeps polling until its deadline" "exit $got after $polls polls, wanted 1 after $((WAIT + 1))"
 
 # ---------------------------------------------------------------------------
 # `gh api --paginate` emits one array PER PAGE, so a thread past the page size