fiddlerwoaroof/improvise
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs: correct two stale gotchas, and an assertion message that lied

Browse Source 
Orchestrator doc pass over the comment wave. Each claim was verified against
the tree rather than taken from the queue.

Gotcha 17 recorded the *opposite* of the code: it said float equality was
"currently mixed", with `=`/`!=` on a 1e-10 epsilon and the div-by-zero guard
checking `rv == 0.0` exactly. Both now go through FLOAT_EQ_EPSILON, at four
call sites across eval_expr and its aggregated twin. Rewritten to say so and
to point at context/code/core.md §4.

Gotcha 35 called the doc comment on `Dirty::of` "the only record" of its
derivation. The comment wave moved that reasoning into
context/code/command.md and left the comment holding one line, so the
instruction to re-read on reclassification now names the prose.

design-principles §5 named `Sessions::apply` as dispatch; `apply_checked` is
what `Host` actually calls since improvise-955n answered a whole frame at
once. Both are real, so the row names both.

improvise-mbmf: the_ranking_is_ordered_shares_with_the_unused_features_dropped
asserted a length of 2 from three features — the zero-importance one dropped —
under the message "the zero-importance feature is listed". The message is read
only on failure, which is precisely when it would have described the wrong
behaviour as the requirement. The test name and doc comment were already right.

cargo test --workspace: 1311 passing, unchanged.

Closes improvise-mbmf.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Edward Langley
2026-09-20 10:50:30 -07:00
parent 52507a6678
commit 56ff51e444
4 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
context/design-principles.md
+1 -1
View File
@@ -226,7 +226,7 @@ The pieces already exist and are worth naming as what they are:
| action | `Command` / `ModelCommand` (`improvise-protocol`) |
| reducer | `reduce_view`, and `WidgetCache::apply` per widget |
| store | `ViewState` + the per-widget caches |
| dispatch | `Sessions::apply` — the one door (gotcha 36) |
| dispatch | `Sessions::apply` / `apply_checked` — the one door (gotcha 36) |
So the question to ask of any code in a front end is: **would a third front end
have to write this again?** If yes, it is behaviour and it belongs in the shared