fiddlerwoaroof/improvise
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor: make Model::formulas private, expose read-only accessor

Browse Source 
Previously `pub formulas: Vec<Formula>` allowed any code to call
`model.formulas.push(formula)` directly, bypassing the dedup logic in
`add_formula` that enforces the (target, target_category) uniqueness
invariant.

Making the field private means the only mutation paths are
`add_formula` and `remove_formula`, both of which maintain the invariant.
A `pub fn formulas(&self) -> &[Formula]` accessor preserves read access
for the UI and tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Ed L
2026-03-24 00:18:43 -07:00
parent d99d22820e
commit 5434a60cc4
3 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/model/model.rs
View File

@ -14,7 +14,7 @@ pub struct Model {
pub name: String,
pub categories: IndexMap<String, Category>,
pub data: DataStore,
pub formulas: Vec<Formula>,
formulas: Vec<Formula>,
pub views: IndexMap<String, View>,
pub active_view: String,
next_category_id: CategoryId,
@ -86,6 +86,10 @@ impl Model {
self.formulas.retain(|f| !(f.target == target && f.target_category == target_category));
}
pub fn formulas(&self) -> &[Formula] {
&self.formulas
}
pub fn active_view(&self) -> Option<&View> {
self.views.get(&self.active_view)
}