docs: require tracking GitHub comments/reviews, not just CI checks
Multi-stack agents (especially Cursor cloud) may focus on pr-watch (CI checks only) and miss review feedback. This makes the obligation explicit. AGENTS.md - new 'PR Tracking: Checks AND Reviews' subsection: - Fetch reviews AND comments (reviews are separate API surface) - Codex/ChatGPT reviews arrive as reviews, not comments - Use ./scripts/pr-reviews <n> to see all feedback together - Answer substantive feedback with identity line before done/merge - Re-check after push that reviews target current head SHA - Don't wait indefinitely on Copilot/Codex (quota-limited) - Points to existing wave essay for full workflow context/cloud-agents.md - new 'PR Tracking' section: - Brief summary of the obligation - Points to pr-watch skill for CI, scripts/pr-reviews for reviews - Cross-references AGENTS.md for full details Co-authored-by: Ed Langley <fiddlerwoaroof@users.noreply.github.com>
This commit is contained in:
@@ -65,6 +65,30 @@ automatic dev shell activation.
|
||||
|
||||
See `context/cloud-agents.md` for environment-specific notes (nix, network, etc.).
|
||||
|
||||
### PR Tracking: Checks AND Reviews
|
||||
|
||||
For any PR an agent owns or is working on, **track both CI checks and GitHub comments/reviews**.
|
||||
The `pr-watch` skill handles check status; reviews require separate attention.
|
||||
|
||||
1. **Fetch reviews and comments** — reviews are a separate API surface from the comment thread.
|
||||
Codex/ChatGPT reviews arrive as *reviews* (not comments), so checking only the comment
|
||||
thread misses them. Use `./scripts/pr-reviews <n>` to see bodies, inline comments, and
|
||||
issue comments together.
|
||||
|
||||
2. **Answer substantive review feedback** on the PR before treating the work as done or
|
||||
merging. Every comment you post must open with an identity line naming the model and
|
||||
that it is an agent posting (the repo owner's account is shared).
|
||||
|
||||
3. **Re-check after each push** that new comments/reviews target the current head SHA.
|
||||
A review may target an earlier commit; verify rather than assume.
|
||||
|
||||
4. **Don't wait indefinitely on Copilot/Codex.** Reviews arrive as quota allows; an absent
|
||||
review and an unrequested one look identical. The adversarial review that gates a merge
|
||||
is dispatched by the orchestrator. External reviews are read *in addition*, not instead.
|
||||
|
||||
See "Shipping a wave" and "Read the PR's reviews before merging it" below for the full
|
||||
review workflow, Copilot request mechanics, and how to answer declined findings.
|
||||
|
||||
## Quick Reference
|
||||
|
||||
```bash
|
||||
|
||||
Reference in New Issue
Block a user